Path: utzoo!utgpu!jarvis.csri.toronto.edu!mailrus!wuarchive!gem.mps.ohio-state.edu!ginosko!aplcen!haven!grebyn!escom!al
From: al@escom.com (Al Donaldson)
Newsgroups: comp.os.minix
Subject: Re: Compiling problems, won't link
Summary: a hack, a question about PRIVATE, controller_busy situation
Message-ID: <491@escom.com>
Date: 28 Sep 89 16:19:26 GMT
References: <15214@bcsaic.UUCP>
Organization: ESCOM Corp., Oakton, VA
Lines: 29

In article <15214@bcsaic.UUCP>, paula@bcsaic.UUCP (Paul Allen) writes:
> While linking the kernel, asld complained
> about "_control multiple declared" in table.c.

I fixed the same problem by renaming "controller_busy" to "zcontroller_busy" 
so cc would generate a unique label.  (Its a dirty hack, I know..)
Only thing I can figure is that Marty's patches are with respect to 
1.3b, while you and I were trying to apply them to a 1.3d release.
A conflicting label must have been introduced (in table.s) between 
1.3b and 1.3d.

What I don't understand is why the "PRIVATE controller_busy" declaration
doesn't automatically restrict the scope or visibility of the label just 
to the wini compilation unit (wini.c).  Obviously, I'm missing something.

Although this is off the point of Paul's question, it does appear
that there are still people trying to integrate Marty's patches,
either to make the 6 MHz AT work properly or to fix other problems.
Last week I suggested to Andy Tanenbaum that Marty's patches should
become part of the next release, and Andy asked that I check with
Bruce Evans about it and also post a question to the network.  Bruce 
replied via mail that he has some changes for the controller_busy code,
so I figured things were under control and I didn't need to pollute
the net with any more comp.os.minix.at_wini questions.  

Anyway, it does appear that the at_wini situation is being cleaned up
for V1.4b.

Al Donaldson