Path: utzoo!utgpu!attcan!uunet!husc6!bu-cs!buengc!bph From: bph@buengc.BU.EDU (Blair P. Houghton) Newsgroups: comp.sources.games.bugs Subject: Re: Repost: Omega inventory bug fix w/o extraneous patch info Message-ID: <874@buengc.BU.EDU> Date: 19 Aug 88 09:23:20 GMT References: <749@james.nprdc.arpa> <498@bruce.oz> Reply-To: bph@buengc.bu.edu (Blair P. Houghton) Followup-To: comp.sources.games.bugs Organization: Boston Univ. Col. of Eng. Lines: 25 In article <498@bruce.oz> cjs@bruce.oz (Chris Stuart) writes: >From article <749@james.nprdc.arpa>, by malloy@nprdc.arpa (Sean Malloy): >> >> This patch fixes the bug that causes objects in your inventory to lose >> their descriptions, i.e., the 'blessed +1' bug. [...] >return pointers to constant >strings rather than use the global buffer Str4 (both methods are bad >programming pratice, so why worry) and then all object name could point >directly to those strings. This would save a LOT of memory space, and take >much less string handling overhead. "...both methods are *bad* programming practice?" I don't know if I ever would do a string copy in a situation like this. Using the constant strings exclusively and only bothering with the pointers seems like good practice, to me; then again, I tend to revert to assembly-style programming when I don't have my "higher- level language" wings on :-). Anyway, it seems that problem has just disappeared when I play the game. I think I'll go try to break it and see exactly where it comes up... --Blair