Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Path: utzoo!mnetor!genat!cmq1!yonatan
From: yonatan@cmq1.UUCP (Jonathan Hanna)
Newsgroups: news.software.b
Subject: Re: 2.11 news src patch #3 (slight mistake)
Message-ID: <287@cmq1.UUCP>
Date: Tue, 30-Dec-86 12:26:15 EST
Article-I.D.: cmq1.287
Posted: Tue Dec 30 12:26:15 1986
Date-Received: Tue, 30-Dec-86 18:55:41 EST
References: <43045@beno.seismo.CSS.GOV>
Reply-To: yonatan@cmq1.UUCP (Jonathan Hanna)
Organization: CMQ Communications Inc., Toronto, Canada
Lines: 18
Summary: typo in news 2.11 patch 3 affecting non-BSD systems without lockf

In Patch #3 of news 2.11:
| + #ifdef BSD4_2
| + 	flock(fileno(actfp), LOCK_UN);
| + #else	/* !BSD4_2 */
| + #ifdef	LOCKF
| + 	lockf(fileno(actfp), F_ULOCK, 0);
| + #else	/* !LOCKF */
| + 	UNLINK(ACTIVE, bfr);
	       ^^^^^^^ <-- I believe should be : UNLINK(bfr);
| + #endif /* V7 */
	     ^^ <-- should be LOCKF (to be consistent)
| + #endif	/* !BSD4_2 */

If this gets by cpp (mine just gave a warning) inews may delete your active
file (actually rename it) and lock up the news system.
-- 
	Jonathan Hanna	{ihnp4,linus,decvax}!utzoo!yetti!cmq1!yonatan
				     seismo!mnetor!genat!cmq1!yonatan