Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Path: utzoo!decvax!ucbvax!BRL.ARPA!ron
From: ron@BRL.ARPA.UUCP
Newsgroups: mod.protocols.tcp-ip
Subject: Re:  4.3 BSD TELNET vs. 
Message-ID: <8612301145.aa27372@SEM.BRL.ARPA>
Date: Tue, 30-Dec-86 11:45:45 EST
Article-I.D.: SEM.8612301145.aa27372
Posted: Tue Dec 30 11:45:45 1986
Date-Received: Wed, 31-Dec-86 01:52:48 EST
Sender: daemon@ucbvax.BERKELEY.EDU
Organization: The ARPA Internet
Lines: 36
Approved: tcp-ip@sri-nic.arpa

The problem occurs only in local echo mode and is a bug in the code
rather than a design feature....


Description:
	TELNET sends \n in local echo mode rather than \r\n when
	\r is typed.
Repeat-By:
	Get into mode 3, character at a time with local echo in
	telnet and then type \r.
Fix:
	The code that decides what the user really meant when he
	the input character is \n has a bug.  It checks to see if
	the user was in CRMOD which would imply that he really
	pressed return rather than linefeed.  The test however is
	defective in that mode 2 has CRMOD set as well.

*** telnet.c	Tue Dec 23 21:50:35 1986
--- /tmp/foo	Tue Dec 30 11:29:50 1986
***************
*** 983,989 ****
  				 * on our local machine, then probably
  				 * a newline (unix) is CRLF (TELNET).
  				 */
! 				if (globalmode >= 3) {
  					NETADD('\r');
  				}
  				NETADD('\n');
--- 983,989 ----
  				 * on our local machine, then probably
  				 * a newline (unix) is CRLF (TELNET).
  				 */
! 				if (globalmode >= 2) {
  					NETADD('\r');
  				}
  				NETADD('\n');