Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP Posting-Version: version B 2.10.1 6/24/83; site kovacs.UUCP Path: utzoo!watmath!clyde!cbosgd!ihnp4!houxm!vax135!cornell!uw-beaver!tektronix!hplabs!sdcrdcf!randvax!kovacs!day From: day@kovacs.UUCP (Dave Yost) Newsgroups: net.lang.c Subject: C Style Wishes Message-ID: <263@kovacs.UUCP> Date: Mon, 30-Sep-85 01:57:07 EDT Article-I.D.: kovacs.263 Posted: Mon Sep 30 01:57:07 1985 Date-Received: Fri, 4-Oct-85 06:06:58 EDT Organization: Robt Abel & Assoc, Hollywood Lines: 37 A few suggestions: I am porting a large system (which shall remain nameless) to the Gould. I have found one bug already, which was caused by the lack of signed characters on the Gould. So, what do you suppose I do next? Of course, I decide to go through all the code looking for all the char declarations to see where else this problem may bite. Of course, I use the handy `grep' utility. But the declaration style used makes my grep output incomplete. I find lots of declarations like: register char *cp, c; Please, folks, use register char *cp; register char chr; instead. It helps when you need to do a grep, and if the declarations have register storage class, as here, it helps you count register declarations (or better yet, you can prioritize them with Reg1, Reg2, etc. as defined for the host machine in a standard include file). And while I'm at it, most of us look at C source as manifested on a screen through an editor, rather than with ink on paper, and often, we want to look at all the places where a variable is referenced. Ever notice that searches for single-letter variable names tend to find lots of stuff you aren't looking for? Thanks. Now I'll go and put on my asbestos suit for a couple of weeks. --dave