Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP Posting-Version: version B 2.10 Apollo; site apollo.uucp Path: utzoo!watmath!clyde!akgua!mcnc!decvax!wivax!apollo!rees From: rees@apollo.uucp (Jim Rees) Newsgroups: net.news.b Subject: Re: Fix for "Not contributor" - USG strchr Message-ID: <268@apollo.uucp> Date: Sat, 17-Mar-84 14:13:43 EST Article-I.D.: apollo.268 Posted: Sat Mar 17 14:13:43 1984 Date-Received: Mon, 19-Mar-84 07:26:50 EST References: <7799@mgweed.UUCP> Organization: Apollo Computer, Chelmsford, Mass. Lines: 22 I'm not convinced. The file funcs.c contains source code for index() and rindex(). Makefile compiles this source file with the flags "-Dindex=strchr -Drindex=strrchr". So you end up with a funcs.o containing definitions for strchr and strrchr, and they certainly don't make use of the hardware instructions. When inews is bound together by ld, all of the calls to strchr and strrchr will be pointed at the ones defined in funcs.o, not the fast assembler-coded ones in /lib/libc.a. It seems to me that we should: 1. Drop the definitions of index() and rindex() from funcs.c. 2. Leave the -Dindex=strchr in the USG version of Makefile. 3. Sites that don't have either index-rindex or strchr-strrchr will just have to write them, or we could send along the definitions from funcs.c but in a separate source file. Alternatively, if we are going to continue to suppply index()-rindex() in funcs.c, it makes absolutely no sense to leave the -Dindex stuff in the makefile, as far as I can tell.